Repository navigation
Fix subplot_of_mapper crash on interferometer data_subtracted - #297
Merged
Jammy2211 merged 1 commit intoMay 3, 2026
Merged
Conversation
Panel 0 of `subplot_of_mapper` and `subplot_mappings` passed `inversion.data_subtracted_dict[mapper]` directly to `plot_array`, which expects a 2D array. For interferometer fits the entry is `Visibilities` (1D), so `plot_array`'s `array.shape[:2]` unpack failed. Mirror the existing `Visibilities` check in panels 1-3: when the dict entry is `Visibilities`, transform to a 2D dirty image via `inversion.transformer.image_from(...)` (same mechanism as `FitInterferometer.dirty_residual_map`). Imaging path unchanged.
Collaborator
Author
Smoke Test Results — 2026-05-03
36 tests passed. 6 failures in euclid_strong_lens_modeling_pipeline failures (all 6 scripts, same root cause)All 6 euclid scripts fail with a workspace/library version mismatch that predates this PR: This is a pre-existing issue with the canonical Affected scripts (all same error):
The 5 workspaces exercising the changed code path ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
subplot_of_mapperandsubplot_mappingspanel 0 crashed on every interferometer pixelization fit withValueError: not enough values to unpack (expected 2, got 1). The panels passedinversion.data_subtracted_dict[mapper]straight toplot_array, which expects a 2D array — but for interferometer fits the entry isVisibilities(1D complex).This mirrors the existing
Visibilitieshandling already used by panels 1-3: when the data isVisibilities, transform to a 2D dirty image viainversion.transformer.image_from(...)— the same callFitInterferometer.dirty_residual_mapuses. The imaging path is untouched.Fixes the 3 release-prep failures grouped as Cluster G + Cluster H in
PyAutoBuild/test_results/runs/2026-04-29T14-48-47Z/triage.md:autogalaxy_workspace/scripts/interferometer/features/pixelization/fit.pyautolens_workspace/scripts/interferometer/features/pixelization/fit.pyautolens_workspace_test/scripts/interferometer/visualization.pyAPI Changes
None — internal change to a plot helper.
subplot_of_mapper/subplot_mappingssignatures unchanged; behaviour for imaging fits is byte-identical. Interferometer fits previously crashed in panel 0; they now render a dirty data-subtracted image.See full details below.
Test Plan
python scripts/interferometer/features/pixelization/fit.py(autogalaxy_workspace) — passespython scripts/interferometer/features/pixelization/fit.py(autolens_workspace) — passespython scripts/interferometer/visualization.py(autolens_workspace_test) — passes; rectangular + delaunay inversion subplots producedpython scripts/imaging/features/pixelization/fit.py(autolens_workspace) — sanity, imaging path unchangedpython -m pytest test_autoarray/inversion/— 162 passedFull API Changes (for automation & release notes)
Removed
Added
Changed Behaviour
Migration
🤖 Generated with Claude Code